Skip to content

Remove unused parameter from scheduler/utils/setStatus#27814

Open
Juanadelacuesta wants to merge 2 commits intomainfrom
NMD-396-set-status
Open

Remove unused parameter from scheduler/utils/setStatus#27814
Juanadelacuesta wants to merge 2 commits intomainfrom
NMD-396-set-status

Conversation

@Juanadelacuesta
Copy link
Copy Markdown
Member

@Juanadelacuesta Juanadelacuesta commented Apr 9, 2026

Description

This PR removes the nextEval parameter from the function setStatus because it is not being used anywhere.

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@Juanadelacuesta Juanadelacuesta changed the title style: remove unused parameter from scheduler/utils/setStatus Remove unused parameter from scheduler/utils/setStatus May 4, 2026
@Juanadelacuesta Juanadelacuesta marked this pull request as ready for review May 4, 2026 09:40
@Juanadelacuesta Juanadelacuesta requested review from a team as code owners May 4, 2026 09:40
@Juanadelacuesta Juanadelacuesta added backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/2.0.x backport to 2.0.x release line backport/ent/2.0.x+ent backport to 2.0.x+ent release line labels May 4, 2026
@mismithhisler mismithhisler self-requested a review May 6, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/ent/1.11.x+ent backport to 1.11.x+ent release line backport/ent/2.0.x+ent backport to 2.0.x+ent release line backport/2.0.x backport to 2.0.x release line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant